23 replies to this topic

[czbird]

Hello Boki,
I'm experiencing strange behaviour of NextGrid (version 5.4.1) related to the Down Arrow key.
It just does not let me reach the latest visible row. Please check the attached sample project.

Thanks & Regards,
Jan

Attached Files

•  sample_project.rar   416.16KB   1 downloads

[Boki (Berg)]

Hi,

I will test it now.

Thank you.

[Boki (Berg)]

Hi Jan,

Inside AddChildRow procedure from NextGrid.pas add:

  if FCells.Row[Index].Shown and (Pos > FLastVisibleRow)
    then FLastVisibleRow := Pos;

I hope that now works.

[czbird]

Hi Boki,
Thank you for your suggestion.
I have added the code to the below place in NxGrid.pas.
It seems to have helped. Please confirm that this is the correct location.

procedure TNextGrid.AddChildRow(const Index: Integer;
  Position: TChildRowPosition);
var
  Pos, j: Integer;
begin
  case Position of
    crFirst: Pos := Index + 1;
    else Pos := Index + FCells.GetChildCount(Index) + 1;
  end;
  FCells.AddChildRow(Index, Pos);

  if goUseDefaultValues in Options then { using default values may slow down adding rows }
  begin
    for J := 0 to Columns.Count - 1 do
      if Columns[J].DefaultValue <> '' then Cells[J, Pos] := Columns[J].DefaultValue;
  end;

  if FCells.Row[Index].Shown and (Pos > FLastVisibleRow) { fix down arrow issue }
    then FLastVisibleRow := Pos;

  if not IsUpdating then
  begin
    if FCells.Row[Index].Expanded then
      ShowRow(Pos, RowSize, True);

    if FCells.Row[Index].ChildCount = 1 then
      RefreshRow(Index);
  end;

  FLastAddedRow := Pos;
  UpdateVertScrollBar;
end;

[czbird]

Hi Boki,
the END and PAGE DOWN keys now move focus beyond the last visible row.
Please check with the same sample project.

Thanks,
Jan

[Boki (Berg)]

Hi Jan,

Please try with next code:

procedure TNextGrid.AddChildRow(const Index: Integer;
  Position: TChildRowPosition);
var
  Pos, j: Integer;
begin
  case Position of
    crFirst: Pos := Index + 1;
    else Pos := Index + FCells.GetChildCount(Index) + 1;
  end;
  FCells.AddChildRow(Index, Pos);

  if goUseDefaultValues in Options then { using default values may slow down adding rows }
  begin
    for J := 0 to Columns.Count - 1 do
      if Columns[J].DefaultValue <> '' then Cells[J, Pos] := Columns[J].DefaultValue;
  end;

  if not IsUpdating then
  begin
    if FCells.Row[Index].Expanded then
      ShowRow(Pos, RowSize, True);

    if FCells.Row[Index].ChildCount = 1 then
      RefreshRow(Index);
  end;

  { Update FLastVisibleRow }
  if FCells.Row[Index].Shown and (Pos > FLastVisibleRow)
    then FLastVisibleRow := Pos;

  FLastAddedRow := Pos;

  UpdateVertScrollBar;
end;

[Boki (Berg)]

Hi,

Please try to modify next line:

  { Update FLastVisibleRow }
  if FCells.Row[Pos].Shown and (Pos > FLastVisibleRow) // <------- modified
    then FLastVisibleRow := Pos;

Please tell me how it works now.

[czbird]

Thanks, Boki.
The sample project is now working fine.
I still have some issues in the main project, so I'll update the sample project and post it again.

[czbird]

Hi Boki, please check attached sample project 2.
Now, the grid is filled a little bit differently - in two separate cycles:
1) parents + level 1 children
2) level 2 children

Again, down arrow will not let you reach the last visible row.

Thanks,
Jan

Attached Files

•  sample_project2_sent_to_boki_on_110907.rar   413.91KB   1 downloads

[Boki (Berg)]

Hi,

I think that I have solved it. Can you please contact me via e-mail to I send you updated files.

One notice: Please use NextGrid1.Expanded[x] := True/False; instead of NextGrid1.Row[x].Expanded := True/False;

Best regards

[czbird]

Hi Boki,
thanks for the news. I've sent you an email and am awaiting the updated files.

Regarding your note: In the sample project 2, if I change

Grid.Row[i].Expanded := false;

with

Grid.Expanded[i] := false;

, then all level 2 children remain visible.

Anyway, I'll check it again with the updated files.

Regards,
Jan

[Boki (Berg)]

Hi Jan,

I have solve this problem too

I have contacted you via e-mail.

Best regards

[czbird]

Hi Boki,
Things are getting better and better
The Down Arrow now seems to be working correctly.

Have you also tried Page Down key? It scrolls beyond the last row (see picture).

Attached Files

•  page_down.jpg   66.3KB   0 downloads

[Boki (Berg)]

Hi Jan,

I will check it now. Please sorry for this problems.

Best regards

[Boki (Berg)]

Hi,

I think that now is fixed I will do some testings and then send you on same e-mail address you have provide to me.

Best regards

[czbird]

Hi Boki, sorry to inform you that the latest version behaves the same as the previous.
Down Arrow is OK, but Page Down takes you beyond last row.
In the Sample Project 2, just push Page Down three times after the grid is filled.

Regards,
Jan

EDIT:
By latest version, I mean this code in AddChildRow:

if Row[Pos].Shown then
  begin
    { Update FLastVisibleRow }
    if Pos > FLastVisibleRow
      then FLastVisibleRow := Pos;
  end else Inc(FLastVisibleRow);

[Boki (Berg)]

Hi Jan,

I have tested it with your demo and seems to work fine. I will send you files once again. Maybe when I zip files I didn't save them previously.

Best regards

[Boki (Berg)]

Hi Jan,

Now I spotted it. I am working on it.

[Boki (Berg)]

Hi Jan,

I have fixed it, completely I will send you files tomorrow. Thank you for your patience.

Best regards

[czbird]

Thanks for the update.
I will check it and get back to you with the result.
Regards,
Jan