12 replies to this topic

[jz]

So today I decided to add FastMM4 to a small project that uses the berg components and it quickly found all sorts of leaks

In about 15 minutes I tracked these down:

CODE

constructor TNxPageControl.Create(AOwner: TComponent);

begin

...

 FCloseBtnBitmap := TBitmap.Create; // never released





constructor TNxLinkLabel.Create(AOwner: TComponent);

begin

...

 FGlyph := TBitmap.Create; // never released





constructor TNxHeaderPanel.Create(AOwner: TComponent);

begin

...

 FHeaderFont := TFont.Create; // never released

 FGlyph := TBitmap.Create; // never released





constructor TNxFlipPanel.Create(AOwner: TComponent);

begin

...

 FMargins := TNxMargins.Create; // never released





constructor TNxFlipContainer.Create(AOwner: TComponent);

begin

...

 FCanvas := TControlCanvas.Create; // never released





constructor TNxGlyphButton.Create(AOwner: TComponent);

begin

...

 FBufferBitmap := TBitmap.Create; // guess!

 FDownImage := TBitmap.Create;

 FHoverImage := TBitmap.Create;

 FImage := TBitmap.Create;

I'm sure there are many more but I got bored looking for them after I noticed a disturbing pattern: you don't even bother to code destructors for many classes!!

I suggest you download FastMM4 (it's free and open source) and compile it into all of your demo programs which make heavy use of the components (and generate lots of leaks). I sincerly hope the next release will not have any leaks at all.

[Raymond]

Is this the MM on sourceforge?

Can you provide a link?

Thanks,
-Raymond

[jz]

http://sourceforge.n...rojects/fastmm/

When you exit your program it will tell you how much memory was leaked.

[Boki (Berg)]

Hello,

I will fix them all. And I will download this prog for sure! Thanks.

regards

[Raymond]

Are you going to download the older stable 4.27 release

or the newer beta release 4.35???


Thanks,
-Raymond

[Boki (Berg)]

Hello,

I have download version 4.35. I only now need to learn how to use it

regards

[Raymond]

LOL!

I understand all too well...

Thanks for the info, looks interesting!

-Raymond

[wvd_vegt]

Hi,

Perhaps interesting to a few of us: MemCheck a tool I used for quite some time to trace leaks, found at

http://v.mahon.free....eware/memcheck/

Unlike FastMM it does't replace the Borland Memory Manager but sits in between the Memory Manager and the Application and monitors all (de)allocations made.

[Raymond]

Thanks Wim!!!

As my eyes get older... these tools can be of more help!

-Raymond

[daniel_r]

Hello,

Unlike FastMM it does't replace the Borland Memory Manager but sits in between the Memory Manager and the Application and monitors all (de)allocations made.

That's true, but that has never been the primary purpose of FastMM. FastMM is a memory manager, which is much faster than the RTL MM and - as far as I know - Borland has already agreed to use FastMM in future products. The memory leak checking and the memory corruption checking is really useful, but merely a side-product.

Regards,
Daniel

[wvd_vegt]

Hi,

I totally agree with you, I just wasn't to comfortable swapping the Borland thing I'm using for years. Until borland uses it in it's products, I probably only use it for memory checking.

Memcheck therefor is handy for those who want to stick to Borland's but want some checks to be done.

I must say that fastmm4 does track some more bugs down (found some nasty ones in a lanman api where unicode strings where one byte short).

[jz]

Found one more in the lastest version.


constructor TNxGlyph.Create(AOwner: TComponent);
begin
FGlyph := TBitmap.Create; // not released

[Boki (Berg)]

Hello,

Thank you, I have add it.

Best regards