7 replies to this topic

[Biblin]

There seems to be a bug with the Insert method of TNextGrid.

Insert(TNxTextColumn, 1) does the following:

Creates the column
Sets the parent component to itself (Which adds it to the Columns collection)
Calls InsertColumn which also adds it to the columns collection.

The column gets added twice which results in the column count being 1 more than actually exists and therefore an Index Out of Bounds error occurs.

The only way to insert a column without this error that I can see is to create the column yourself and then call InsertColumn instead.

[Boki (Berg)]

Hello,

You are correct. I will fix it now. Thank you.

regards

[Biblin]

Cheers, now that's service

Second bug while you're at it. Insert doesn't actually seem to insert, it just adds.

Checking through the code it looks like you insert the item into the correct position in FItemList and add it to the end of FPositionItemsList which is the list actually used for positioning. Shouldn't it be the other way around?

[Boki (Berg)]

Hello Biblin,

Comment line where it stay: SetParentControl(). This line is not needed.

regards

[william]

Hello Biblin,

Comment line where it stay: SetParentControl(). This line is not needed.

regards

It should be SetParentComponent., and what about Biblin's second bug report?

William

[Boki (Berg)]

Hello,

Here is complete procedure:

CODE

function TNxColumns.Insert(ColumnClass: TNxColumnClass; Pos: Integer): TNxCustomColumn;
begin
  Result := ColumnClass.Create(Self);
  Result.FColumns := Self;
  with Owner as TNxCustomGrid do
  begin
    Result.Color := Color;
    Result.Cursor := Cursor;
    Result.Font.Assign(Font);
  end;
  InsertColumn(Result, Pos);
end;

Please note that after inserting column you need to se Position for column (!)

regards

[william]

Hello,

Please note that after inserting column you need to se Position for column (!)

regards

Hi, Boki

Thanks. but why don't set the position inside the Insert procedure itself?

William

[Boki (Berg)]

Hello William,

I will think about it. Until then, you may use next code

NextGrid1.Columns.Insert(TNxTextColumn, 4).Position := 4;

regards