10 replies to this topic

[flavsouvou]

I ve got a integer overflow on this line in function BlendColor in Nxshareddraw.pas line 101 :


Result := Integer(
((Cardinal(UpColor) and $FF00FF) * Cardinal(Amount) +
(Cardinal(DownColor) and $FF00FF) * Value) and $FF00FF00 +
((Cardinal(UpColor) and $00FF00) * Cardinal(Amount) +
(Cardinal(DownColor) and $00FF00) * Value) and $00FF0000) shr 8;


Play with the demo and click on the 2 buttons to open and close iForm2.


The pb occurs occasionnaly after clicking several times.

Attached Files

•  Project1.zip   602.82KB   4 downloads

[Boki (Berg)]

Hi flavsouvou,

Can you please send me a source of this demo project. It will help me to find a problem.

Thank you,

Best regards

[flavsouvou]

see attached

Attached Files

•  test.zip   1.45MB   4 downloads

[Boki (Berg)]

see attached

Hi,

First, thank you for your demo,

For some reason, when I have delete components that I don't have, bug don't occur any more.

Can you please check attached exe file and try to reproduce bug.

Maybe you can send me a other demo without additional components to I test it.

Best regards

Attached Files

•  Project1.zip   375.54KB   0 downloads

[flavsouvou]

I ve noticed the same behavior.

That s strange.

[Boki (Berg)]

Hi,

Maybe some additional component made a problem.

Best regards

[flavsouvou]

when pgscrollbuttons is set to false, the problem is solved.
I think you ve got a pb in TnxpageControl...

[Boki (Berg)]

Hello,

It may be some problem with additional components. If you can somehow reproduce it without them this will be great.

Best regards

[vhorky]

Hi,
I have the same problem with fatal error "Integer overflow" in BlendColor method.
I have to change source code to:

class function TGraphicsProvider.BlendColor(Color1, Color2: TColor; Amount: Integer): TColor;
var
Value: Integer;
v,a,c1,c2 :Int64;
begin
Assert(Amount in [0..255]);
Value := Amount xor 255;
if Integer(Color1) < 0 then Color1 := GetSysColor(Color1 and $000000FF);
if Integer(Color2) < 0 then Color2 := GetSysColor(Color2 and $000000FF);

c1 := Color1;
c2 := Color2;
a := Amount;
v := Value;

Result := (((
((c1 and $FF00FF) * a +
(c2 and $FF00FF) * v) and $FF00FF00 +
((c1 and $00FF00) * a +
(c2 and $00FF00) * v) and $00FF0000) shr 8) and $FFFFFFFF);
end;

[Boki (Berg)]

Hello,

Thank you Vhorky. I will test it tomorrow with your fix.

Problem is since I never receive this problem, to be able to solve it.

Thank you again

Best regards

[user22]

Hi,

i think this is the same problem i reported some month ago:
http://www.bergsoft....?showtopic=3590

bye,
Helmut