7 replies to this topic

[Markus]

Hi,

could somebody please give me a possible use case for GetItemByName()? I suspect the function doesn't exactly do what it's supposed to do.

Markus

[Boki (Berg)]

Hello,

This property return Item with specified name. Example:

CODE

NextInspector1.Items.ItemByName['testitem'].Caption := 'BorderWidth';

I hope that this help,

Regards

[Markus]

CODE

NextInspector1.Items.ItemByName['testitem'].Caption := 'BorderWidth';

Ok, I see. In this case the function works as expected.

Markus

[wvd_vegt]

Hi Boki,

Ok, I see. In this case the function works as expected.
Markus

Is it an idea & possible to make this function case insensitive or would that break to much existing code?

Another request is to add a Name parameter to the AddChild call so you can compact code like:

CODE

NextInspector1.AddChild(TNxTextItem, 'Voornaam', 'VoornaamItem'). AsString := Klanten[ndx].Voornaam;

and

CODE

voornaam:=NextInspector1.Items.ItemByName['VoornaamItem'].AsString;

[Markus]

Hi Wim,

Is it an idea & possible to make this function case insensitive or would that break to much existing code?

Why would you want to make this function case-insensitive? This property is very useful when dealing with items at runtime, i.e. creating and destroying them at runtime. Considering this use-case there's one problem: You can assign the same string to multiple name properties. Therefore I'm against making this function case-insensitive as this would allow more redundant name property choices.

Another request is to add a Name parameter to the AddChild call so you can compact code like:

CODE

NextInspector1.AddChild(TNxTextItem, 'Voornaam', 'VoornaamItem'). AsString := Klanten[ndx].Voornaam;

and

CODE

voornaam:=NextInspector1.Items.ItemByName['VoornaamItem'].AsString;

Yeah, I'm in favor of this change. Just define AddChild as this

CODE

function AddChild(ItemClass: TNxItemClass; S: string = ''; Name: String = ''): TNxPropertyItem;

and you're still compatible with one's old code.

Cheers,
Markus

[wvd_vegt]

Hi Markus,

Hi Wim,
Why would you want to make this function case-insensitive? This property is very useful when dealing with items at runtime, i.e. creating and destroying them at runtime. Considering this use-case there's one problem: You can assign the same string to multiple name properties. Therefore I'm against making this function case-insensitive as this would allow more redundant name property choices.

Markus

Good point, BUT as you cannot have two objects shareing the same name, Delphi is case in-sensitive there (and the function works on the Name property of the item only as I discovered) it would not matter at all (or am I wrong here?). It would be different if the GetItemByName function where to act on the Caption property.

If it would be as you describe, I totally agree it's a bad move.

[Markus]

Hi Wim,

Delphi is case in-sensitive there (and the function works on the Name property of the item only as I discovered) it would not matter at all (or am I wrong here?).

No, you're right. I was wrong in my assumption that you can assign the same name to multiple controls at run-time! Just tested that and it turned out that this results in an exception. Sorry for the fuss.

So, after all, I'm +1 on making the function case-insensitive.

Cheers,
Markus

[wvd_vegt]

Hi Markus,

Hi Wim,
No, you're right. I was wrong in my assumption that you can assign the same name to multiple controls at run-time! Just tested that and it turned out that this results in an exception. Sorry for the fuss.

So, after all, I'm +1 on making the function case-insensitive.

Markus

Actually you can AS long as the controls reside on different forms. But that would automatically mean a different NextInspector too.