7 replies to this topic

[bertrod]

Hello,

In :

TNxCustomNumberEdit.GetValue(), there is a StrToFloat() and I had problems if the user enters very large numbers (overflow exception).

I suggest you put a try-except around the StrToFloat().

What do you think ?

Regards

[Boki (Berg)]

Hello Bertrod,

I am not sure that I understand, can you please tell me where you have locate this line (or send me one small example) and I will add it.

Best regards

[wvd_vegt]

Hi,

There is also TryStrToFloat with built-in exception handling.

Hello,

In :

TNxCustomNumberEdit.GetValue(), there is a StrToFloat() and I had problems if the user enters very large numbers (overflow exception).

I suggest you put a try-except around the StrToFloat().

What do you think ?

Regards

[bertrod]

Here is my TNxCustomNumberEdit.GetValue function in NxEdit.pas with the StrToFloat :

CODE

function TNxCustomNumberEdit.GetValue: Double;
var
  ValidText: string;
begin
  if Text = '' then Result := 0 else
  begin
    ValidText := GetValidText(Text, eoAllowFloat in FOptions, eoAllowSigns in FOptions);
    if ValidText = '' then ValidText := '0';
    Result := StrToFloat(ValidText);
    CheckBounds(Result);
  end;
end;

Sorry if this line has already been corrected in a more recent version. As wvd_vegt says, using TryStrToFloat should be already enough.

Regards

[Boki (Berg)]

Hello Bertrod,

Please try with next update:

CODE

function TNxCustomNumberEdit.GetValue: Double;
var
  ValidText: string;
begin
  if Text = '' then Result := FMin else
  begin
    ValidText := GetValidText(Text, eoAllowFloat in FOptions, eoAllowSigns in FOptions);
    if ValidText = '' then ValidText := FloatToStr(Min);
    TryStrToFloat(ValidText, Result);
    AdjustToRange(Result);
  end;
end;

Best regards

[wvd_vegt]

Hi Boki,

According to the help files, TryStrToFloat nothing is said about the value parameter if the function returns false.

Technically you should code something like:

CODE

if TryStrToFloat(ValidText, Result) then
  AdjustToRange(Result)
else
  result:=Min; //or some other value, probably the old/previous value

[code=auto:0]
ValidText := GetValidText(Text, eoAllowFloat in FOptions, eoAllowSigns in FOptions);
if ValidText = '' then ValidText := FloatToStr(Min);
TryStrToFloat(ValidText, Result);
AdjustToRange(Result);

[Boki (Berg)]

Hello Wim,

Maybe this could be final code:

CODE

function TNxCustomNumberEdit.GetValue: Double;
var
  ValidText: string;
begin
  if Text = '' then Result := FMin else
  begin
    ValidText := GetValidText(Text, eoAllowFloat in FOptions, eoAllowSigns in FOptions);
    if ValidText = '' then ValidText := FloatToStr(Min);
    if TryStrToFloat(ValidText, Result) then
    begin
      AdjustToRange(Result);
      FValue := Result;
    end else Result := FValue;
  end;
end;

Previously declare FValue in private section and set

CODE

FValue := 0;

inside Create of TNxCustomNumberEdit

Best regards and thanks

[wvd_vegt]

Hi Boki,

Looks ok to me.