10 replies to this topic

[DiGi]

Bug in new version - setter SetAsDateTime should not trim TIME part from TDateTime.

[Boki (Berg)]

Hello Digi,

Nothing have changed in this procedure since version 3.x. Can you please send me small demo project to I see where is a problem and how this procedure should work. Thank you.

Kind regards

[DiGi]

I'm not sure - Diff from SubVersion server:

Revision 5592: Update to NextSuite v4.5.09.1
Revision 5591: NextGrid Suite v4.7.8.1


Index: NxCellClasses.pas
===================================================================
--- NxCellClasses.pas (revision 5591)
+++ NxCellClasses.pas (revision 5592)
@@ -217,7 +217,7 @@

function TDateTimeCell.GetAsInteger: Integer;
begin
- Result := Round(FValue);
+ Result := Trunc(FValue);
end;

function TDateTimeCell.GetAsString: WideString;
@@ -233,7 +233,7 @@

procedure TDateTimeCell.SetAsDateTime(const Value: TDateTime);
begin
- FValue := Value;
+ FValue := Trunc(Value);
inherited;
end;

[Boki (Berg)]

Hello Digi,

I didn't remember why I have change it. I will need to think a little bit about returning Round instead of trunc.

Best regards

[Boki (Berg)]

Hello Digi,

I don't know what to do. Since it is a DateColumn, it is more suitable that it accept only Date part of TDateTime.

I may add for you a switch ($IFDEF) which you may set and column will work as in version 4.7.8.1

Please tell me what you think.

Best regards

[DiGi]

Oh, i missed that... Simple DateTime column can be fine, just with this one modification. Using two columns as date AND time is now waste of space...

Date column works fine until this update.

[Boki (Berg)]

Hello Digi,

I have change this since one year ago upon a requests. Please tell me if is ok to I add one switch for you which you may change and for you DateColumn will work as before.

Best regards

[DiGi]

It it simple to "cut" time part just by using FormatMask in TNxDateColumn.

Cell is "TDateTimeCell" so it should handle time part too. It it possible to insert Time part using AsFloat (for now ;-)), but I'm not sure that it is correct.

New property AsDate with Trunc is in my opinion better than modify old and correct behavior.

[Boki (Berg)]

Hello Digi,

I will need to think a little bit more. Maybe you are correct.

Best regards

[vhorky]

I'm not sure - Diff from SubVersion server:

Revision 5592: Update to NextSuite v4.5.09.1
Revision 5591: NextGrid Suite v4.7.8.1


Index: NxCellClasses.pas
===================================================================
--- NxCellClasses.pas (revision 5591)
+++ NxCellClasses.pas (revision 5592)
@@ -217,7 +217,7 @@

function TDateTimeCell.GetAsInteger: Integer;
begin
- Result := Round(FValue);
+ Result := Trunc(FValue);
end;

function TDateTimeCell.GetAsString: WideString;
@@ -233,7 +233,7 @@

procedure TDateTimeCell.SetAsDateTime(const Value: TDateTime);
begin
- FValue := Value;
+ FValue := Trunc(Value);
inherited;
end;

Hi Digi and Boki,
I have the same problem with using this type of column. I think it is better to use only FValue := Value instead of FValue = Trunc(Value), because the format of datetime "dd.MM.yyy HH:mm:ss" does not work correctly and I must use 2 columns (DateTime and Time). This is not good for reports etc.

[Boki (Berg)]

Hello vhorky and DiGi. I will think once more and decide what to do. I hope that someone else will write on this topic too.

Best regards